search

Sherlock-YH / pe

0 stars 0 forks source link

UG on Cancel Feature #10

Open Sherlock-YH opened 1 year ago

Sherlock-YH commented 1 year ago

Can provide more detail and guideline that ensures the User know when to enter "c/" For example, the user should only enter "c/" without any other characters or it will be mistaken.

image.png

nus-se-script commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

As described in the other issue, this was allowed as we do not want to restrict users input to not ever be able to include "c/" for example if they have a username: "tic/toc" it would not trigger the Operation Cancel. Yet the Cancel Operation command must be a simple command people can have access to quickly. The result is that the input must specifically be just "c/".

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to cancel in the mid of entering username

it does not cancel the current operation and take c/ into the username.

image.png

image.png

[original: nus-cs2113-AY2223S2/pe-interim#1063] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

type "c/" is different than type "sd s c/"

The cancel operation can only be done when it is entered solely. Otherwise, the first intended command that you entered in (in this case, username) will be taken instead, and the "c/" will be assumed to be part of the username. The developer does not want to restrict user's username

Please refer to user guide in whole for any discrepancies.

image.png

For these reasons, we kept it as such. But in the future we may have better ways for users to cancel operation to improve this part of user experience.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]