search

Sherlock-YH / pe

0 stars 0 forks source link

Able to save expired CreditCard #3

Open Sherlock-YH opened 1 year ago

Sherlock-YH commented 1 year ago

image.png

nus-se-script commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

This is an intended feature. We are considering users who may want to store details of their expired credit cards. Eg: users may want to refer back to billing information of an expired credit card, and details of the expired credit card stored in SecureNUS will be useful.

Therefore expired cards can still be stored in the system

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

"new o/CreditCard" command accepts expiration date in the past

When using the "new o/CreditCard" command, the application allows the user to input an expiration date which has already past (or is too far into the future to be possible). I believe this is inconsistent with some of the other behaviour of the application. For instance, the application verifies that the credit card number and CVC are in the correct format so why should it not verify that the expiration date is possible.

Steps to reproduce:

  • Input the following sequence of commands:

image.png

[original: nus-cs2113-AY2223S2/pe-interim#1787] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As a Feature, some users may opt to save their older, expired credit cards. Different banks have also different terms of Credit Card Expiry date timeline (5 years, 4 years, etc). Since we want to be inclusive to everyone, we do not restrict these.

For these reasons, we kept it as such in this iteration. But we may improve the checking and even reminding for expiry dates in future iterations.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]