search

ShioR / EVE-Character-Showroom

An EVE Online API based web app that shows users their characters skill and the ships they can fly. This is the open source core for evesp.com and the now-offline eve-sheet.com.
https://evecs.evesp.com
GNU General Public License v3.0
11 stars 3 forks source link

Trailing Slash #36

Closed jamesronan closed 12 years ago

jamesronan commented 12 years ago

Hi,

Having now bothered to install the Webapp and have a play (rather than just guessing) I've fixed the trailing slash issue (It's the way Apache's mod_rewrite was capturing everything as the Regex was a little to liberal)

I've tested this on my local version and it works.

Original Commit message:

The issue was the way that Apache mod_rewrite was working. Adding a negative lookahead I made it not pass "skillsheet.php" as the character name request param, thus not confusing the EVE class.

ShioR commented 12 years ago

Hi again James,

Many thanks for your work and the explanation. I've just tested it and it works on the live site and locally, so I'm more than happy to merge.