ShokoAnime / Shokofin

Repository for Shokofin, a plugin that brings Shoko to Jellyfin.
https://shokoanime.com
MIT License
148 stars 18 forks source link

Shokofin not fetching trailers/credits #65

Closed sannidhyaroy closed 3 months ago

sannidhyaroy commented 3 months ago

Jellyfin version.

10.9.8

Shokofin version.

4.1.1.0

Shoko Server version, release channel, and commit hash.

4.2.2 Stable

File structure of your Media Library Folder in Jellyfin/Import Folder in Shoko Server.

../Anime Title/Season X/S0XE0Y: Episode Title

Screenshot of the "library settings" section of the plugin settings.

Screenshot 2024-07-30 at 7 40 19 PM Screenshot 2024-07-30 at 7 40 32 PM

Library Type(s).

Shows

Do the issue persists after creating a library with Shoko set as the only metadata provider? (Now is your time to check if you haven't already.)

Issue

Shokofin doesn’t add trailers for a series (not yet tested for movies, so unsure about that) into a trailers folder that Jellyfin supports. I have VFS turned on, so I can’t manually add a trailer either. The same goes for credits as well, but I can live without it, although support for that would be great as well.

Stack Trace

No response

revam commented 3 months ago

is this a shows type library, or a mixed type library?

edit: i will learn to read some day.

revam commented 3 months ago

are the trailers recognised in shoko?

revam commented 3 months ago

Also, just to be sure, but you don't see this icon in the UI? Screenshot_20240730_164503_Jellyfin

sannidhyaroy commented 3 months ago

are the trailers recognised in shoko?

I'm new to Shoko, so I'll ask this, just to be sure: Will Shoko fetch trailers from some online source or do I have to place a trailer into my import folders, and Shoko can check the hash to detect it as a trailer?

If the answer is that Shoko automatically fetches trailers from an online source, is there any way to check that Shoko has indeed fetched a trailer and the issue is specific to Shokofin?

revam commented 3 months ago

shoko onpy provide local tdaileds (for mow at least) that are recognised by shoko itself.

sannidhyaroy commented 3 months ago

Also, just to be sure, but you don't see this icon in the UI?

That icon shows up as YouTube Trailers Plugin was enabled for me. If Jellyfin has fetched a YouTube Trailer and there exists a trailers folder, Jellyfin will prioritize the media inside trailers and ignore the YouTube Trailers completely.

Since, clicking on that icon loads up a YouTube Trailer, I suspected Shokofin didn't create a trailers folder. I confirmed the lack of such folder, when I looked inside the VFS folder to see there were Season X folders with symlinks to my episodes, but no trailers folder.

I have disabled YouTube Trailers as 90% of the trailers that Jellyfin fetches are region-restricted, so it doesn't load up.

sannidhyaroy commented 3 months ago

shoko onpy provide local tdaileds (for mow at least) that are recognised by shoko itself.

So, I have to manually place a trailer content in my import folders and Shoko should recognize it as a trailer. Is that correct?

EDIT: I downloaded a trailer from YouTube and threw it in Shoko's import folder. It categorized it as "Unrecognized".

revam commented 3 months ago

You can either

revam commented 3 months ago

EDIT: I downloaded a trailer from YouTube and threw it in Shoko's import folder. It categorized it as "Unrecognized".

That is intended behaviour if hash recognition doesn't work btw. You need to manually link anything that is not indexed on AniDB (or add it if it's a public release, which the downloaded youtube video is not).

revam commented 3 months ago

If there is a plugin that places files in a trailer sub-directory for the show/season then it should in theory work fine even with the VFS (provided they've written it to work with relative paths the same way Jellyfin would resolve the trailers). Not that I've done any research to check if there are any.