search

ShokoAnime / Shokofin

Repository for Shokofin, a plugin that brings Shoko to Jellyfin.
https://shokoanime.com
MIT License
148 stars 18 forks source link

Specials Position not handled properly #66

Closed sannidhyaroy closed 3 months ago

sannidhyaroy commented 3 months ago
Screenshot 2024-07-30 at 7 51 14 PM

Specials Placement works perfectly when the default option (placed after normal episodes) is selected. #37 resolved the last option as well (to exclude specials within seasons). The remaining options still don’t work for me (yes, I have deleted and recreated the library), and selecting any of those will just work as the default option (place specials after seasons).

revam commented 3 months ago

Last time I checked, then the release date option works fine (using it for my library). But I can try to investigate if that still is the case in 10.9.

sannidhyaroy commented 3 months ago

Last time I checked, then the release date option works fine (using it for my library). But I can try to investigate if that still is the case in 10.9.

For more context, I noticed it in the anime called "The Dangers in my Heart" or "BokuYaba". I have Season 1 and Season 2 and 1 OVA (inside Specials). The OVA is released after Season 1 and before Season 2, but Shoko places it at the end of Season 2, no matter what.

I can see that Shokofin has set the release date of the OVA correctly, but using the Release Date option in Shoko still places it after Season 2.

Expected Result:

The OVA should be placed either after the episodes of Season 1 or before the episodes of Season 2. When Shoko is disabled and TVDB is used on a library, this expected result is achieved.

revam commented 3 months ago

Looking at the AniDB entries then the expected result would be to place it in season 2, before all normal episodes.

My brain is telling me that there might be a flaw in the placement logic episodes that would be placed before all episodes in the season because we determing the placement based the previous normal episode, which there is none off. I'll look at it after work to see if it can be improved upon.

revam commented 3 months ago

I'll get to this next time I have time to sit down and fix the minor inconveniences that have cropped up so far.

sannidhyaroy commented 3 months ago

I'll get to this next time I have time to sit down and fix the minor inconveniences that have cropped up so far.

No problem, please take your time. Thanks for this amazing plugin.

revam commented 3 months ago

Do re-open the issue if this didn't fix it. @sannidhyaroy

Also, you may need to manually clear the specials placement data if it's incorrect… on every affected episode you want to fix it, or just recreate the whole library from a clean slate. I don't know if they've made it so the specials placement is cleared when you do a full rescan of the metadata in 10.9, but it certainly wasn't so in 10.8.