Shoobx / xmldiff

A library and command line utility for diffing xml
MIT License
204 stars 52 forks source link

Get version with importlib.metadata #110

Closed KRunchPL closed 1 year ago

KRunchPL commented 1 year ago

pkg_resources that was used to get package version is a deprecated API: https://setuptools.pypa.io/en/latest/pkg_resources.html

regebro commented 1 year ago

Thanks!

If I understand correctly, we don't need the backport on Python 3.8, when importlib.metadata is in Python? In that case, let's hold off until we drop support for 3.7, otherwise, we'll just have another bit of old code to remove later, which means we didn't really gain anything.

regebro commented 1 year ago

OK, implemented, thanks!