search

Shoobx / xmldiff

A library and command line utility for diffing xml
MIT License
204 stars 52 forks source link

Is setuptools still needed in install_requires? #132

Closed SFrijters closed 2 months ago

SFrijters commented 6 months ago

After pkg_resources was removed in https://github.com/Shoobx/xmldiff/pull/124 and the minimum Python requirement bumped in https://github.com/Shoobx/xmldiff/pull/123, is there any reason to still require it at runtime?

regebro commented 2 months ago

It's not required or used at runtime, but it is still the packaging solution we use.

SFrijters commented 2 months ago

setuptools is the default [1] for installation, and install_requires only specifies what the program needs at runtime.

[1] "Note that if there is no pyproject.toml file or the build-backend parameter is not defined, then the fall-back behaviour is to use setuptools." - https://setuptools.pypa.io/en/latest/build_meta.html

regebro commented 2 months ago

OK. It also doesn't hurt if it's there. I'll try removing it at some point and see.

SFrijters commented 2 months ago

Sure, it's not vital, just a small cleanup. If you get around to it, then great!