Shopify / polaris

Shopify’s design system to help us work together to build a great experience for all of our merchants.
https://polaris.shopify.com
Other
5.77k stars 1.17k forks source link

Create new multiselect autocomplete component #4964

Closed laurkim closed 2 years ago

laurkim commented 2 years ago

Problem

The current flow in admin to interact with tags is in a less than ideal state. Some of the main functions of the existing TagCard component are:

The proposed solution is to build a new multiselect autocomplete component to replace the necessity of the flow to click the "View all tags" to open the modal and be allowed to edit tags.

Tasks

Relevant links

sarahill commented 2 years ago

I've got some questions that I'm just gonna drop here to keep track. Don't need to answer them right now just things I am wondering about that may or may not need to be considered for this project.

General questions

Polaris component questions

Deliver tag work questions

laurkim commented 2 years ago

@sarahill for the deliver tag work question, I was looking specifically at the TagsAutocomplete that is being used in the Deliver team's TagCard. But I think there is also an existing TagsAutocomplete that uses the polaris-next one which is confusing. Maybe the existing TagsAutocomplete hasn't been deprecated yet?

laurkim commented 2 years ago

Oh I think this issue might have context on why autocomplete and checkbox both exist. The autocomplete GitHub label had already existed prior to me making this issue so I'm just looking through some of the history.

laurkim commented 2 years ago

Closing as complete because we've shipped new tag multiselect pattern in Admin and haven't gotten any bug reports in the 60+ mins its been live