The graphql tooling in this codebase predates any community tooling. We didn't use graphql-codegen et al at the time because it didn't exist. Now that community tooling around graphql has gotten much better I would be very interested in seeing if we can leverage community tools now that they exist instead of providing our own tools.
I would prefer it if we leveraged existing tools instead of having to maintain our own. This reduces our maintenance burden and there is more chance that devs shall be familiar with community tooling.
I’d like to tackle some of this work after we get Apollo3 rolled out in in #2302 and https://github.com/Shopify/web/pull/68796 (otherwise we end up with too many breaking changes at once). It’s a slow process though.
+1 graphql-typescript-definitions can't be run in Node 18 because of engine constraints on dependency. It's difficult to work with these packages and the new Apollo packages.
The graphql tooling in this codebase predates any community tooling. We didn't use graphql-codegen et al at the time because it didn't exist. Now that community tooling around graphql has gotten much better I would be very interested in seeing if we can leverage community tools now that they exist instead of providing our own tools.
I would prefer it if we leveraged existing tools instead of having to maintain our own. This reduces our maintenance burden and there is more chance that devs shall be familiar with community tooling.
Ideas:
@shopify/graphql-testing
with@apollo/core/testing
graphql-config-utilities
, per https://github.com/Shopify/quilt/issues/2385I’d like to tackle some of this work after we get Apollo3 rolled out in in #2302 and https://github.com/Shopify/web/pull/68796 (otherwise we end up with too many breaking changes at once). It’s a slow process though.