Shopify / shipit-engine

Deployment coordination
https://shopify.engineering/introducing-shipit
MIT License
1.42k stars 144 forks source link

Upgrade Rails to 7.1.1 #1322

Closed kartiki975 closed 8 months ago

kartiki975 commented 9 months ago

What does this PR change?

This PR involves a lot of changes. I highly suggest reviewing changes commit by commit.

Focus for reviewers

Due to some limitations, I had to manually do this upgrade. Please carefully these changes! Most important of all is the encryption algorithm change. Reading through the section, it doesn't seem anything applies to this repo since config.active_support.key_generator_hash_digest_class was never manually configured. If someone could give that a check, please leave 👍!

Aside

Rails 7.2 is expected to officially deprecate Rails.application.secrets in favor of Rails.application.credentials. This will be handled in a follow up PR.

kartiki975 commented 8 months ago

@casperisfine Hey, Jean! I had to manually upgrade rails and a bunch of other dependencies for some internal Shopify ticket which is due tomorrow. Could you please take a look at these changes?

kartiki975 commented 8 months ago

Closing this out in favour of https://github.com/Shopify/shipit-engine/pull/1324