Shopify / shopify-api-ruby

ShopifyAPI is a lightweight gem for accessing the Shopify admin REST and GraphQL web services.
MIT License
1.06k stars 473 forks source link

Fix docs webhooks.md #1141

Closed Nittarab closed 1 year ago

Nittarab commented 1 year ago

Description

The Webhooks.md guide is a bit inconsistent with the current library

  1. as explained here #945 the WebhookHandler module need to extend the ShopifyAPI::Webhooks::Handler
  2. path is a required argument of ShopifyAPI::Webhooks::Registry#add_registration

Checklist:

Nittarab commented 1 year ago

I signed the CLA but idk how to run this check again

github-actions[bot] commented 1 year ago

This pull request is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

Nittarab commented 1 year ago

@paulomarg do you want to take a look?

Nittarab commented 1 year ago

@mllemango Thank you. I have update the PR to remove the conflicts