Consistent Session Cookie Value While Embedded Mode Allows Fallback

berniechiu commented 1 year ago

Description

Fixes #1158

Please, include a summary of what the PR is for:

What is the problem it is solving? Embedded mode allows session cookie fallback, but we don't assign anything to the cookie under embedded mode.
What is the context of these changes? Make cookie creation consistent with session.
What is the impact of this PR? Make the fallback work as usual.

How has this been tested?

Please, describe the tests that you ran to verify your changes.

Checklist:

[x] My commit message follow the pattern described in here
[x] I have performed a self-review of my own code.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] I have updated the project documentation.
[x] I have added a changelog line.

lizkenyon commented 11 months ago

Hi there 👋

Thank you for submitting this PR, but we can't accept it at this time. We removed the use of cookies for embedded apps because browsers are phasing out(or already have) the use of third party cookies due to security concerns.

This is why we introduced App Bridge.

If you are looking at how to implement this in Ruby, I would recommend looking at our app template.

berniechiu commented 11 months ago

Well...if I may clarify, the code still present in the Shopify API Ruby, no? If it has not been removed, this could potentially lead to confusion and logical inconsistencies.

Shopify / shopify-api-ruby