Closed nelsonwittwer closed 1 year ago
I think this breaks webhooks processing for mandatory webhooks.
The @registry[request.topic]
will be nil
for mandatory webhooks because they were skipped in https://github.com/Shopify/shopify-api-ruby/blob/82e4caf30c21a67a68384b5abcc897884dbc5065/lib/shopify_api/webhooks/registry.rb#L25-L27
Yep, I can confirm that too. Mandatory webhooks in v13.3.0 are broken. Please rollback this PR.
Thanks for the quick fix! 🙏
Description
Friction with mandatory webhooks was identified in the shopify app gem. Since Mandatory webhooks aren't subscribed to via API, we need to gracefully skip them during registrations without breaking handlers.
This skips registration/unregistration for mandatory topics that are managed in the partner dashboard
How has this been tested?
Unit tests within this library. I've also created a new app using our ruby app template pointing to this branch and my fix to the app gem's branch to verify I could recreate webhook without error.
Checklist: