Shopify / shopify-api-ruby

ShopifyAPI is a lightweight gem for accessing the Shopify admin REST and GraphQL web services.
MIT License
1.06k stars 473 forks source link

Use ShopifyAPI::Clients::HttpClient instead of HTTParty directly in OAuth.validate_auth_callback #1239

Closed brendo closed 1 year ago

brendo commented 1 year ago

RE: #1235

Description

This PR replaces a direct call to HTTParty with the HttpClient included by this library. Whilst this doesn't change much from a consumer's perspective, internally it means a monkey patch on HttpClient to use the internal domain covers all HTTP requests originating from this library.

How has this been tested?

At the moment, just the unit tests in this project.

Checklist: