Shopify / shopify-app-js

MIT License
232 stars 91 forks source link

Build Failure when upgrading to Latest Shopify API #793

Open Praveen2106 opened 3 months ago

Praveen2106 commented 3 months ago

Issue summary

After upgrading from Shopify API 8.1.1 to 9.7.1, the following errors occur while building the application.

node_modules/@shopify/shopify-api/runtime/crypto/crypto.d.ts:1:23 - error TS2688: Cannot find type definition file for '@cloudflare/workers-types'.

1 /// <reference types="@cloudflare/workers-types" />

node_modules/@shopify/shopify-api/runtime/http/types.d.ts:1:23 - error TS2688: Cannot find type definition file for '@cloudflare/workers-types'.

1 /// <reference types="@cloudflare/workers-types" />

However, no issues with "npm run dev". The application runs without any issues.

Are there any changes needed when upgrading to the latest version? We could not find any documentation for the same,

lizkenyon commented 3 months ago

Hi there 👋

Could you share what your package.json looks like?

Praveen2106 commented 3 months ago

I've attached the package.json file below. Kindly let me know if you need anything else. Thanks!

package.json

eyoeldefare commented 3 months ago

They seem to break everything every time they upgrade their libraries. Look at their libraries, its barely production grade.

Praveen2106 commented 3 months ago

I upgraded to 9.7.2 and this issue is not found now. But from the changes, I could not see what fixed this.

github-actions[bot] commented 1 month ago

We're labeling this issue as stale because there hasn't been any activity on it for 60 days. While the issue will stay open and we hope to resolve it, this helps us prioritize community requests.

You can add a comment to remove the label if it's still relevant, and we can re-evaluate it.