search

Shopify / themekit

Shopify theme development command line tool.
https://shopify.dev/tools/theme-kit
MIT License
1.2k stars 375 forks source link

Checksum inconsistencies for JSON assets prevents files being skipped #779

Open andyw8 opened 4 years ago

andyw8 commented 4 years ago

Describe the bug

The latest version of Theme Kit does not seem to handle some JSON files. It calculates a different checksum locally than on the server, so files without changes are still uploaded/downloaded, even if they haven't changed.

To Reproduce Steps to reproduce the behavior:

  1. Add a new Simple theme for a store, and configure Theme Kit with its theme ID.
  2. Run theme download.
  3. Run theme download a second time.

Expected behavior

Most files should be skipped, but the JSON files will be re-downloaded.

Environment (please complete the following information):

Additional context

This may be theme dependent, or only affect newer themes – I previously tested against other themes and didn't run into this.

cameronrr commented 3 years ago

Might be something to do with encoding or escaping. But I prevented all my locales/*.json files redownloading for no apparent reason every time by deploying all the local files which weren't being skipped. Haven't noticed any side effects.