Update documentation - Githubissues

Shopify / themekit

Shopify theme development command line tool.

https://shopify.dev/tools/theme-kit

MIT License

1.2k stars 375 forks source link

Update documentation #788

Closed Andrewngabriel closed 4 years ago

Andrewngabriel commented 4 years ago

I've updated the documentation for the new command to include a table with optional flags and indicate that by default the command will use the current directory and not create a new one.

Fixes #753, #795

Warn Checklist

[ ] This changes the interface and requires a Major/Minor version change.
[ ] I have :tophat:'d these changes by using the commands I changed by hand.
[ ] I have added a dependancy to the project.
[x] I have considered any potential impact on node-themekit

Andrewngabriel commented 4 years ago

I've signed the CLA but it's still showing the error. Any reason why that's the case @tanema @chrisbutcher ? Can I re-run it?

tanema commented 4 years ago

Hey @Andrewngabriel I fixed the CLA bot. Can you also update the help in the command? https://github.com/Shopify/themekit/blob/master/cmd/new.go#L17-L22

Andrewngabriel commented 4 years ago

@tanema Just updated it!

Andrewngabriel commented 4 years ago

I saw issue #795 this morning and figured this PR is still open and it's related to documentation, I might as well update it.

Andrewngabriel commented 4 years ago

Fixed

tanema commented 4 years ago

thanks again for your help!