Wrong content when updating locales files

[stefankunze]

When change the content of our language json file locally and deploy it on our production theme we do not get the changes applied. Even more strange if you change the file before in "Edit Code" in Shopify it gets replaced with an old version of the file, not the one edited and saved nor the one pushed from our local machines.

Steps to reproduce the behavior:

1. Change file content locally
2. deploy file with themekit

Expected behavior local changes should be applied to the theme

Environment (please complete the following information):

• Environment: MacOS 10.15
  • Themekit version: ThemeKit 1.1.1 and ThemeKit 1.0.3
• Editor: SublimeText3 and PHPStorm

---

Recorded a video in loom where you can see the case https://www.loom.com/share/586a4b2c814044e5a6af1d0609a4317a

[andyw8]

Hi @stefankunze

Thank for the detailed report, and especially the video.

I'm wondering, when you click on Older Versions in the online editor, do you see any revisions containing the updates you made locally?

[stefankunze]

@andyw8 Thanks for your response - we also checked the older versions, but the content uploaded wasn't in there either.

[andyw8]

Thanks, I've checked our logs for that particular asset and it seems the update is not reaching our servers.

I'd like to first determine if it's related to the watch command or not. Could you try stop the watch, make an edit, and then push it using using theme deploy locales/en.default.json --verbose, and share the output.

(also, if you're on the Partners Slack then you can message me on there, might make it quicker to resolve this).

[vvo]

@andyw8 I also have a locale related issue (ticket id 20789131). And I was able to understand it a bit more.

When I use the watch command for my theme, if I update a locale in the shopify admin interface, my local locale files are not updated. The theme watch command does not download locale updates from shopify.

If I do a brand new theme get command then I do get the updated locale files. BTW I think this watch issue is not just for locale files but for a lot of other files, because at some point I did a deploy of my watched theme and it broke A LOT of my live theme, most changes done on the shopify admin UI itself were not reflected in my local files..

Finally, a brand new get command right now get stuck at 97% (theme id: 115209928855) and never finishes.

[tanema]

Finally, a brand new get command right now get stuck at 97% (theme id: 115209928855) and never finishes.

Please see #801

[tanema]

When I use the watch command for my theme, if I update a locale in the shopify admin interface, my local locale files are not updated. The theme watch command does not download locale updates from shopify.

I was reviewing issues and just wanted to point out that this is not how theme watch works. Shopify does not send themekit events of your changes on shopify. If you want changes made in the admin, then you will need to run theme download.

Watch will only watch for you local changes, and we will not be implementing any sort of events from shopify to your local system.

[tanema]

@stefankunze

When change the content of our language json file locally and deploy it on our production theme we do not get the changes applied. Even more strange if you change the file before in "Edit Code" in Shopify it gets replaced with an old version of the file, not the one edited and saved nor the one pushed from our local machines.

This all sounds like an intermittent cache/cdn failure. Is this problem still happening? What shopify does when you make changes to a file is that they get sent to a cdn to be served for your site however sometimes there are connection issues or other intermittent issues that cause files to not get update or delayed.