UpdateOptions are not reflected after moving the tree

[Ttayu]

Warning: I will close the issue without the minimal init.vim and the reproduction instructions.

Problems summary

Once the tree is moved, the option changes made by updateOptions are not reflected. I only checked the matcher part, so it is possible that this is a different issue

Expected

The options should be changed regardless of whether the tree is moved or not.

Environment Information

• ddu-ui-filer version (SHA1): 8f3e8c8669b25017cd0b44b4f401d8eb9af8e9ad

• denops.vim version (SHA1): 68f607d93a9758d15c0d63d3268aa420ddd29edd

• deno version(deno -V output): deno 1.37.1

• OS:

  PRETTY_NAME="Ubuntu 22.04.3 LTS"
  NAME="Ubuntu"
  VERSION_ID="22.04"
  VERSION="22.04.3 LTS (Jammy Jellyfish)"
  VERSION_CODENAME=jammy
  ID=ubuntu
  ID_LIKE=debian
  HOME_URL="https://www.ubuntu.com/"
  SUPPORT_URL="https://help.ubuntu.com/"
  BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
  PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
  UBUNTU_CODENAME=jammy

TODO: MacOS version

• neovim/Vim :version output:

  
  NVIM v0.10.0-dev
  Build type: RelWithDebInfo
  LuaJIT 2.1.0-beta3
  Compilation: /usr/bin/cc -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wvla -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -fno-common -Wno-unused-result -Wimplicit-fallthrough -fdiagnostics-color=auto -fstack-protector-strong -DUNIT_TESTING -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_TS_HAS_SET_MAX_START_DEPTH -I/usr/include/luajit-2.1 -I/usr/include -I/build/neovim-8HEGtO/neovim-0.10.0~ubuntu1+git202309281605-28ffd96c9-9b397864c/.deps/usr/include -I/build/neovim-8HEGtO/neovim-0.10.0~ubuntu1+git202309281605-28ffd96c9-9b397864c/build/src/nvim/auto -I/build/neovim-8HEGtO/neovim-0.10.0~ubuntu1+git202309281605-28ffd96c9-9b397864c/build/include -I/build/neovim-8HEGtO/neovim-0.10.0~ubuntu1+git202309281605-28ffd96c9-9b397864c/build/cmake.config -I/build/neovim-8HEGtO/neovim-0.10.0~ubuntu1+git202309281605-28ffd96c9-9b397864c/src
  
  system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

## Provide a minimal init.vim/vimrc without plugin managers (Required!)

```vim
" Your minimal init.vim/vimrc
set runtimepath+=~/.cache/dein/repos/github.com/vim-denops/denops.vim
set runtimepath+=~/.cache/dein/repos/github.com/Shougo/ddu.vim
set runtimepath+=~/.cache/dein/repos/github.com/Shougo/ddu-source-file
set runtimepath+=~/.cache/dein/repos/github.com/Shougo/ddu-kind-file
set runtimepath+=~/.cache/dein/repos/github.com/Shougo/ddu-ui-filer
set runtimepath+=~/.cache/dein/repos/github.com/Shougo/ddu-filter-matcher_hidden
set runtimepath+=~/.cache/dein/repos/github.com/Shougo/ddu-commands.vim

autocmd TabEnter,CursorHold,FocusGained <buffer>
      \ call ddu#ui#do_action('checkItems')
augroup DduFilerSettings
  autocmd!
  autocmd FileType ddu-filer call s:ddu_filer_settings()
augroup END

function! s:ddu_filer_settings() abort
  nnoremap <buffer> h
        \ <Cmd>call ddu#ui#do_action('itemAction',
        \ #{ name: 'narrow', params: #{ path: '..' } })<CR>
  nnoremap <buffer> >
      \ <Cmd>call ddu#ui#do_action('updateOptions', #{
      \   sourceOptions: #{
      \     file: #{
      \       matchers: ToggleHidden('file'),
      \     },
      \   },
      \ })<CR>
  nnoremap <buffer><expr> l
        \ ddu#ui#get_item()->get('isTree', v:false) ?
        \ "<Cmd>call ddu#ui#do_action('itemAction', #{ name: 'narrow' })<CR>" :
        \ "<Cmd>call ddu#ui#do_action('itemAction', #{ name: 'open' })<CR>"
  nnoremap q <Cmd>call ddu#ui#filer#do_action('quit')<CR>
endfunction

function! ToggleHidden(name)
  let current = ddu#custom#get_current(b:ddu_ui_name)
  let source_options = get(current, 'sourceOptions', {})
  let source_options_name = get(source_options, a:name, {})
  let matchers = get(source_options_name, 'matchers', [])
  return empty(matchers) ? ['matcher_hidden'] : []
endfunction

call ddu#custom#patch_global({
      \   'ui': 'filer',
      \   'sources': [
      \     {
      \       'name': 'file',
      \       'params': {},
      \     },
      \   ],
      \   'sourceOptions': {
      \     'file': {
      \       'matchers': ['matcher_hidden'],
      \     },
      \   },
      \   'kindOptions': {
      \     'file': {
      \       'defaultAction': 'open',
      \     },
      \   },
      \   'actionOptions': {
      \     'narrow': {
      \       'quit': v:false 
      \     },
      \   },
      \   'uiOptions': {
      \     'filer': {
      \       'toggle': v:true 
      \     },
      \   },
      \   'uiParams': {
      \     'filer': {
      \       'split': 'floating',
      \       'sort': 'filename',
      \       'sortTreesFirst': v:true,
      \       'toggle': v:true,
      \     },
      \   },
      \ })

nnoremap ,n <Cmd>Ddu -name=filer<CR>

How to reproduce the problem from neovim/Vim startup (Required!)

1. ,n to start Ddu filer
2. > to check that the mather is switched and mathcer_hidden and '' are swapped
3. l or h to move tree
4. h or l to return to original position (not always necessary)
5. > to change matcher, but not changed

Screenshot (if possible)

Upload the log messages by :redir and :message (if errored)

[Shougo]

Reproduced. But it is not reproduced in my config.

[Ttayu]

Ah, now we know why. nnoremap ,n <Cmd>Ddu -name=filer -sync file<CR> That solved the problem. Thank you very much.

[Shougo]

I get the reason. It is bug.

[Shougo]

fixed.