Skillcheck SVGs with proxy

BohnSeb commented 2 years ago

Environment Details

Foundry VTT Version: 9, Build 280
Operating System: Ubuntu 20.04
How Are You Using Foundry: Chrome and Firefox over Webserver
Which Game System: DnD5e 1.6.3
Modules Enabled?: yes: Better Rolls for 5e, Actually private Rolls

Issue Description

When using a reverse Proxy with Foundryvtt, the SVGs of Skillchecks like "Insight" can't be loaded, because of the chat-portrait module ignoring the "routePrefix" option in the options.json. This results in the resource getting requested at the wrong uri.

Example

If the domain is "www.foundryserver.com" the proxy takes all requests to the address "http://www.foundryserver.com/server1" and routes them to "localhost:30000". The corresponding options.json needs to have the proxyPort, hostname and routePrefix set. In this example the routePrefix would be "server1". Here is an comparison when rolling an insight check and chat-portrait is trying to load the "insight.svg" resource:

Expected behaviour: GET http://www.foundryserver.com/server1/modules/chat-portrait/assets/insight.svg
Present behaviour: GET http://www.foundryserver.com/modules/chat-portrait/assets/insight.svg

The chat-portrait module should include the "routePrefix" option from the options.json into their request-Strings. vtt-options

BohnSeb commented 2 years ago

Missing-insight-icon Thats what it looks like in the chat

p4535992 commented 2 years ago

Should be solved with 0.8.0, try out and let me know

ShoyuVanilla / FoundryVTT-Chat-Portrait