ShrRa / python-intermediate-development

Intermediate Python for Astronomical Software Development
https://shrra.github.io/python-intermediate-development/
Other
3 stars 4 forks source link

episode 25 - adding pylint and nbqa to requirements #11

Closed mpgh closed 5 days ago

mpgh commented 5 days ago

Without adding pylint and nbqa to the requirements the build will stop:

Run python3 -m pylint --fail-under=0 --reports=y lcanalyzer /opt/hostedtoolcache/Python/3.11.9/x64/bin/python3: No module named pylint Error: Process completed with exit code 1.

etc.

CI will pass successfully after updating the requirements.txt. Adding this from the start might avoid similar issues.

RileyWClarke commented 5 days ago

Aren't pylint and nbqa already supposed to be added to the requirements back in Section 1?

Screenshot 2024-07-02 at 12 48 21 PM
mpgh commented 5 days ago

you are right. When going through the material, I must have skipped the freeze. Accordingly, if other participants skip this step the issue will appear