ShwetKhatri2001 / AR-Webstore

Webstore built to showcase photorealistic 3D digital objects in AR
https://ar-webstore.netlify.app/
MIT License
52 stars 102 forks source link

Form validation in Feedback.js #235

Closed student-aditipaliwal closed 4 months ago

student-aditipaliwal commented 5 months ago

Fixes #230

netlify[bot] commented 5 months ago

Deploy Preview for ar-webstore ready!

Name Link
Latest commit d3aac8345c76c62166fa0b26923895ac7be7f1e9
Latest deploy log https://app.netlify.com/sites/ar-webstore/deploys/65acd2aef3342f0008718190
Deploy Preview https://deploy-preview-235--ar-webstore.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ShwetKhatri2001 commented 5 months ago

Good work @student-aditipaliwal ! Can you make these changes to make it valid for `Easy ' level?

I can merge this after that.

student-aditipaliwal commented 5 months ago

ok I did that and submit it to you tomorrow

On Sun, 21 Jan, 2024, 1:59 PM Shwet Khatri, @.***> wrote:

Good work @student-aditipaliwal https://github.com/student-aditipaliwal ! Can you make these changes to make it valid for `Easy ' level?

  • Name, Email, and the first question What did you like most about AR-Webstore? needs to be mandatory to submit the form. Alert if they are not valid/empty.
  • Similarly add validation to check valid email format and non-empty answer to the first question.
  • Show error messages in light red color and small font size.

I can merge this after that.

— Reply to this email directly, view it on GitHub https://github.com/ShwetKhatri2001/AR-Webstore/pull/235#issuecomment-1902553599, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDDHYL32IZUONPIMGTS7USTYPTGW5AVCNFSM6AAAAABCDZYNF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGU2TGNJZHE . You are receiving this because you were mentioned.Message ID: @.***>

ShwetKhatri2001 commented 5 months ago

Will you be able to complete this in the next few days @student-aditipaliwal ?

ShwetKhatri2001 commented 4 months ago

Closing this PR because of inactivity.