search

ShyykoSerhiy / vscode-spotify

Use Spotify inside vscode(on Mac, Windows, and Linux).
https://marketplace.visualstudio.com/items/shyykoserhiy.vscode-spotify
MIT License
606 stars 74 forks source link

UI glitches: Pause icon incorrect, icon size differs #31

Open perlun opened 6 years ago

perlun commented 6 years ago

Hi!

Thanks for an interesting extension. 👍 I am using it on macOS.

I noted two minor details:

  1. The pause button is slightly "wrong", it looks like a "stop" button instead of pause: https://github.com/ShyykoSerhiy/vscode-spotify/blob/master/src/SpotifyControls.ts#L72
  2. The width of primitive-square and triangle-right differs with a pixel or two, which means that the status bar "jumps around" when you play/pause the music.

Suggestions on how to fix these, and I'll gladly submit a PR.

ShyykoSerhiy commented 6 years ago

Yeah, vscode uses octicons(https://octicons.github.com/) for 'special' characters support (@see https://code.visualstudio.com/docs/extensionAPI/vscode-api#StatusBarItem text property). Sadly there is no 'Pause' octicon. We can try to use pause emoji for this ( https://emojipedia.org/double-vertical-bar/ ) but it will look a bit off. I don't think there is a good solution for this issue.

As for width difference we can try add space character to play or pause button (whichever is smaller).

perlun commented 6 years ago

Alright, we can live with the icon for now. I think the pixel error is perhaps more important.