SiLeBAT / fcl-client

Web app for analyzing food delivery networks
https://silebat.github.io/fcl-client/
GNU General Public License v3.0
7 stars 2 forks source link

Improve FCL banner in ROA PDFs #778

Closed afalenski closed 4 months ago

afalenski commented 7 months ago

As a user I do not want to print a supply chain in which elements of the image (here: FCL banner) is cut off.

Note: This issue did not occur before the last ROA changes (several tickets).

The screenshots show that there is plenty of space below the banner, so the banner could be displayed completely. Perhaps the margins need to be edited...

PDF printed in Firefox:

grafik.png

Zoom in:

grafik.png

PDF printed in Chrome, page 1:

grafik.png

Zoom:

grafik.png

Page 3:

grafik.png
ruegenbfr commented 4 months ago
Why the FCL banner is cut off?

Because of its position. The graph editor shows the page breaks as dashed lines. They are dependent on the page size and the page orientation. The lines show that the page break is in the middle of the FCL banner.

Why is there space in the pdf dodument?

The graph editor reduces the page scale (default 100 %) internally. What ever the user chooses the graph editor uses only 75% of that choice. (The reason for that hard coded scale reduction is given as 'Workaround to match available paper size in actual print output'). If this internal reduction is removed than the cut in the pdf document is usually even bigger. Because usually the browser printer settings respect a margin. The user can choose to print without margin in the printer dialog and than there is no space left in the pdf document. So this hard coded reduction was probably introduced because of the printer margins. The printer margins can be customized in a browser and their default values seem to be different for different browsers.

Proposed solution:

@afalenski decided to reduce at first only the decent vertical box distance. The move of the legend shall be addressed in a separate ticket.

afalenski commented 4 months ago

Banner is not cut off in Firefox or Chrome for Example Dataset and BabyTea Scenario 1. Done.


Tested with Machine: BfR-Laptop

OS: Windows 10

Datasets:

Browsers: