SiLeBAT / fcl-client

Web app for analyzing food delivery networks
https://silebat.github.io/fcl-client/
GNU General Public License v3.0
7 stars 2 forks source link

Add github actions to pull requests. #794

Closed arne-z closed 3 months ago

arne-z commented 3 months ago

Add a github action running build, lint, and test jobs that runs automatically on pull requests.

ruegenbfr commented 3 months ago

Would it be beneficial to use one job instead ? So the setup would run only once, like e.g.:

     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
           node-version: 18
       - id: ci
          run: npm ci
       - run: npm run build:qa
       - if:  ${{ (success() || failure()) && steps.id.outcome=='success' }}
         run: npm run test
       - if:  ${{ (success() || failure()) && steps.id.outcome=='success' }}
         run: npm run lint
arne-z commented 3 months ago

Is this cleared to merge now @ruegenbfr?