search

SigNoz / signoz-web

SigNoz Website
https://signoz.io
Other
8 stars 42 forks source link

improve `OpenTelemetry Setup in a Nodejs Application` article #917

Closed Sachin-chaurasiya closed 1 month ago

Sachin-chaurasiya commented 1 month ago

In this(https://signoz.io/opentelemetry/nodejs/) article, we are using two packages: express and cors. However, the dependency installation step is missing the cors package, so it would be great to add the cors package to the dependency installation step.

Sachin-chaurasiya commented 1 month ago

@YounixM , I would like to work on this issue, could you please assign it to me? thanks!

Calm-Rock commented 1 month ago

@Sachin-chaurasiya, thanks for the issue. I have assigned it to you.

Sachin-chaurasiya commented 1 month ago

@Sachin-chaurasiya, thanks for the issue. I have assigned it to you.

Thanks @Calm-Rock , raised a PR https://github.com/SigNoz/signoz-web/pull/918, please review.