search

SilentChaos512 / Silents-Mechanisms

A simple tech mod for Minecraft
30 stars 12 forks source link

Mixer allows unusable liquids in its inventory #24

Open Partonetrain opened 5 years ago

Partonetrain commented 5 years ago

Hi again, here's another bug report...

Versions

Expected Behavior

Mixer doesn't allow unusable liquids in its inventory.

Actual Behavior

Mixer allows unusable liquids. This would be fine if it was an item-based inventory, but because it's a liquid inventory, you can't take out invalid ingredients, and all you can do is break the block.

Links/Images

image

(Diesel and lava are not usable in the Mixer)

Not sure if there's an easy way to prevent this with a data-driven recipe system. I understand if this is a wontfix.

Partonetrain commented 5 years ago

oh gosh. hit enter too fast. hold on

Didn't realize hitting enter on the title field submits the issue. Sorry about that.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

SilentChaos512 commented 4 years ago

I didn't realize I had stale bot on this repo...

SilentChaos512 commented 4 years ago

Made a small change which prevents the mixer from putting the same fluid in multiple tanks. That should help the issue somewhat.

McKitten commented 4 years ago

I have also managed to put polyethylene back into the mixer and no be able to remove with without moving the mixer.

Perhaps a select output button below each tank icon would assist with other unforeseen items entering it.

davqvist commented 4 years ago

I also encountered this issue and would love a solution for this. In 1.15 I have water in 2 tanks of the mixer somehow and accidently put Diesel in, meaning breaking the block and losing the Diesel is the only real solution.

Best would be obv to check if the fluid is allowed as input for all valid recipes and only allow it if it is. Being able to lock/filter tanks to specific fluids would also work probably. Not sure what is easier for you to implement.

Awesome mod btw, keep up the good work.