SiliconSloth / Metro

Simple and flexible version control and code syncing.
MIT License
1 stars 1 forks source link

VCRUNTIME140_1.dll not found for Alpha 1.0.0 #76

Open SiliconSloth opened 4 years ago

SiliconSloth commented 4 years ago

Issue Description

Running Metro version 1.0.0 Alpha from Command Prompt on Windows shows a popup that states that VCRUNTIME140_1.dll was not found. Metro does not run.

Expected Behaviour

Metro to run normally

Reproducibility

Run Alpha 1.0.0 from Command Prompt

System Details

Windows 10

Release Version

Alpha 1.0.0

Black-Photon commented 4 years ago

Can you verify 'Microsoft Visual C++ 2015-2019 Redistributable (x64)' is installed by going to 'Control Panel/Programs/Programs and Features'

SiliconSloth commented 4 years ago

I have the 2017 version installed, along with several versions 2013 and lower.

Black-Photon commented 4 years ago

I believe that the version required corresponds to the version of Visual Studio used to compile it - in this case 2019. Try installing the 2019 version and see if that fixes it.

SiliconSloth commented 4 years ago

I feel like we shouldn't require random VC dlls to be installed, or at least inform the user. Is there some way to avoid needing this?

Black-Photon commented 4 years ago

We can either statically link it, or use another tool such as MinGW.

SiliconSloth commented 4 years ago

Surely MinGW will have a redistributable library of its own? Could we consider making an installer that installs VC for you?

Black-Photon commented 4 years ago

I think MinGW might use some more common Windows runtime libraries, though I admit that isn't exactly much better. Making an installer could work well - this may be one of the reasons so many Windows applications choose that option.