SillyTavern / SillyTavern-Launcher

Launcher scripts for SillyTavern and ST-Extras.
MIT License
215 stars 58 forks source link

[BUG] install.sh is looping #40

Open Tuerpe opened 8 months ago

Tuerpe commented 8 months ago

Environment

Linux

System

Arch-Linux

Describe the problem

The install.sh is looping. I looked up the script and here:

install_st_extras_post() {
    # Activate the extras environment
    log_message "INFO" "Activating Conda environment extras..."
    conda activate extras

    # Navigate to the SillyTavern-extras directory
    cd "$PWD/SillyTavern-extras"

    # Use the GPU choice made earlier to install requirements for extras
    if [ "$GPU_CHOICE" == "1" ]; then
        log_message "INFO" "Installing modules for NVIDIA from requirements.txt in extras"
        pip3 install -r requirements.txt
        conda install -c conda-forge faiss-gpu -y
        install_st_extras_post
    elif [ "$GPU_CHOICE" == "2" ]; then
        log_message "INFO" "Installing modules for AMD from requirements-rocm.txt in extras"
        pip3 install -r requirements-rocm.txt
        install_st_extras_post
    elif [ "$GPU_CHOICE" == "3" ]; then
        log_message "INFO" "Installing modules for CPU from requirements-silicon.txt in extras"
        pip3 install -r requirements-silicon.txt
        install_st_extras_post
    fi

... it just keeps itself invoking. It doenst get any further. Is this the issue or is it something else why my installation is looping here?

Additional info

No response

Please tick the boxes

deffcolony commented 8 months ago

@Tuerpe could you test if it works now? i made some big changes to the install.sh https://github.com/SillyTavern/SillyTavern-Launcher/commit/afe33f485cdaad7028bbc98d5552c7eef229cada#diff-043df5bdbf6639d7a77e1d44c5226fd7371e5259a1e4df3a0dd5d64c30dca44f