SimVascular / simvascular.github.io-archive

SimVascular website
4 stars 11 forks source link

Integrate SimCardio Guide #83

Closed ktbolt closed 2 years ago

ktbolt commented 3 years ago

Ignoring the README here that states DO NOT edit the master branch files! and not followiing the existing documentation practices the initial SimCardio Guide documentation was incorrectly added to the master branch as html. That was later moved into .erb files but the documentation does not display correctly.

I will add the files to the source branch and see if I can get the documentation to display correctly.

ktbolt commented 3 years ago

I've added the SimCardio section

Screen Shot 2021-06-14 at 11 47 13 AM

But this is what it looks like

Screen Shot 2021-06-14 at 11 46 04 AM
ktbolt commented 3 years ago

I've fixed the major formatting problems and cleaned up the Cardiac Geometric Modeling Tool section a bit, still needs a lot or work though, not very clear what it is and what it does, how to use it, what the outputs are, etc.

Screen Shot 2021-06-14 at 6 59 21 PM
ktbolt commented 3 years ago

The equations in the electrophysiology section were not in the correct MathJax format and contained _ symbols that needed to be escaped.

I fixed all that and now the equations are looking good

Screen Shot 2021-06-14 at 9 45 23 PM
vvedula22 commented 3 years ago

Great! once you are done fixing these issues, I will work on editing the content.

ktbolt commented 3 years ago

I've merged my changes into the source branch.

@vvedula22 I removed the simcardio/electrophysiology/images/ttp_cuboid.gif file, at 17M a bit large to put in GitHub.

CZHU20 commented 3 years ago

@ktbolt Hi Dave, I just submitted a pull request, which should fix the equation display in cardiac mechanics modeling section. Please let me know if there is any issue.

Another suggestion is to replace the Purkinje network visualization (https://simvascular.github.io/documentation/simcardio/electrophysiology/images/purkinje-paraview.png) with a newer one. This one does not look physiologically correct as the fibers branched into the aortic region. @vvedula22 should have some better results.

Thanks.