search

Simon-Initiative / oli-torus

Next Generation OLI Authoring and Delivery Platform
https://proton.oli.cmu.edu
MIT License
94 stars 36 forks source link

Restore undo/redo buttons #1369

Closed eliknebel closed 2 months ago

eliknebel commented 3 years ago

Describe the bug In Safari, Ctrl+Z is a browser level command to reopen last closed tab, therefore we cannot rely solely on these hotkeys for undo/redo in the page editor.

To Reproduce Steps to reproduce the behavior:

  1. Go to a page using Safari
  2. Make some changes, try to undo them

Expected behavior Users should be able to undo/redo changes regardless of browser.

Environment (please complete the following information):

darrensiegel commented 3 years ago

We cannot consider restoring undo/redo buttons to address this, as that approach would require showing undo/redo buttons for every slate editor present on the page. Text-level undo/redo is now Slate editor centric, as opposed to how it was previously when it was Resource level centric.

Perhaps a solution here is to manually add another hot key sequence that triggers Undo within the current active Slate editor.

ThinkThoughtThunk commented 2 years ago

Find a way to handle undo/redo in safari (Verify keystroke used -- can we support multiple? another sequence? A button?)

ThinkThoughtThunk commented 2 years ago

discoverability of hotkey a concern