search

Simon-Lavery / SLTaxi-website

Website for a taxi company
0 stars 0 forks source link

Beginner friendly #2

Open Simon-Lavery opened 4 years ago

Simon-Lavery commented 4 years ago

This repo is open to contributors of all skill levels.

I am a beginner so if you think you can help or you think I can help you get involved

A good place to start might be with me over the next few weeks trying to convert all CSS to great SCSS

Assone commented 4 years ago

Do you still need to convert css to scss, I can help you.

Simon-Lavery commented 4 years ago

I have converted alot of it but I just learned SASS so your welcome to add to it or change anything you think needs improved, that goes for any part of the code

Assone commented 4 years ago

ok, Let me see what I can change.

Assone commented 4 years ago

Hey, there seems to be a file missing from the esj template.

Error: Could not find the include file "./partials/google-analytics"
    at getIncludePath (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:162:13)
    at includeSource (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:306:17)
    at /Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:702:26
    at Array.forEach (<anonymous>)
    at Template.generateSource (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:678:15)
    at Template.compile (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:557:12)
    at Object.compile (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:389:16)
    at handleCache (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:212:18)
    at tryHandleCache (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:251:16)
    at View.exports.renderFile [as engine] (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:482:10)

I can't run this website. In your index.js file, The part about URL jumping, You can put it in the route.

Simon-Lavery commented 4 years ago

Hi sorry, I am not at the computer today, I put the google analytics script in ejs file and must have added it to git ignore, it should work fine in you delete the line where its included

Simon-Lavery commented 4 years ago

Hey, there seems to be a file missing from the esj template.

Error: Could not find the include file "./partials/google-analytics"
    at getIncludePath (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:162:13)
    at includeSource (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:306:17)
    at /Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:702:26
    at Array.forEach (<anonymous>)
    at Template.generateSource (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:678:15)
    at Template.compile (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:557:12)
    at Object.compile (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:389:16)
    at handleCache (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:212:18)
    at tryHandleCache (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:251:16)
    at View.exports.renderFile [as engine] (/Users/reset0/Development/OpenSource/SLTaxi-website/node_modules/ejs/lib/ejs.js:482:10)

I can't run this website. In your index.js file, The part about URL jumping, You can put it in the route.

I had included the google analytics partial in the .gitignore file, I am just getting used to github and wasn't sure if it could be uploaded but it can, should work fine now

Assone commented 4 years ago

cool , I'll try now.