search

SimonAlling / kurve

Achtung, die Kurve! in the browser
https://kurve.se
GNU Affero General Public License v3.0
41 stars 6 forks source link

Check round result before end tick in tests #121

Closed SimonAlling closed 1 month ago

SimonAlling commented 1 month ago

My plan in #120 was that this PR would make it so that if both expectations (round result and end tick) fail, then both of them are reported. That doesn't seem to be how Expect.all works though – it only shows the first one. WDYT we should do, @lydell?

SimonAlling commented 1 month ago

So if we can't have the cake and eat it too, then we should ask ourselves: What provides more information: the end tick or the round result? I believe it's the round result. But when trying to figure out why a test is failing, I think it's typically gonna be easier to temporarily change the expected end tick in order to see how the round ends, compared to the other way around.