search

SimonKagstrom / kcov

Code coverage tool for compiled programs, Python and Bash which uses debugging information to collect and report data without special compilation options
http://simonkagstrom.github.io/kcov/
GNU General Public License v2.0
709 stars 109 forks source link

Use CURL imported target instead of variables set by `find_package` #412

Closed shailpatels closed 7 months ago

shailpatels commented 7 months ago

Patch I made locally to fixes #411

Instead of relying on the variables set by find_package this uses an imported target from the curl cmake files to ensure libcurl is available. I'm not fully sure why find_package wasn't getting the full set of curl libraries required, maybe it was due to multiple installations of libcurl or if it was built locally? But it seems like using an imported target is generally preferred in newer cmake

This did require bumping the min version of cmake supported since the imported target was only added in 3.12. I'm not sure if thats an issue or not, an alternative solution would be to use find_package and explicitly request libcurl as a required component

SimonKagstrom commented 7 months ago

I don't think that should be an issue, in general. However, my (old) ARM/PPC etc github action use an older Ubuntu which doesn't have cmake 3.12, so those have to be updated. I can take a look at that, unless you feel like doing it :-)

Also, the Mac OS big sur build can be disabled now.

shailpatels commented 7 months ago

I don't think that should be an issue, in general. However, my (old) ARM/PPC etc github action use an older Ubuntu which doesn't have cmake 3.12, so those have to be updated. I can take a look at that, unless you feel like doing it :-)

Also, the Mac OS big sur build can be disabled now.

Sure thing! I bumped Ubuntu to ubuntu22.04 and updated the run-on-arch GH action while I was there to the latest version (assuming thats whats preferred) and the macos big sur job should be disabled now

SimonKagstrom commented 7 months ago

Thanks, merging!

There are still some CI issues, but I'll resolve those. The CI was unstable also before your changes, so not caused by you anyway!