SimonKagstrom / kcov

Code coverage tool for compiled programs, Python and Bash which uses debugging information to collect and report data without special compilation options
http://simonkagstrom.github.io/kcov/
GNU General Public License v2.0
709 stars 109 forks source link

ci.yml: update vmactions/freebsd to v1 #421

Closed perillo closed 5 months ago

perillo commented 5 months ago

v1 is the most recommended to use and runs on ubuntu-latest instead of macos-12.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.81%. Comparing base (1e1002e) to head (7419243).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #421 +/- ## ========================================== + Coverage 65.75% 65.81% +0.06% ========================================== Files 58 58 Lines 4520 4520 Branches 4177 4177 ========================================== + Hits 2972 2975 +3 + Misses 1548 1545 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SimonKagstrom commented 5 months ago

Thanks!

Yes, I have another branch where I'm trying to get this working: https://github.com/SimonKagstrom/kcov/tree/fix-freebsd-python2-tests, which also uses v1 now.

However, for some reason, the bash tests no longer works with this one...

perillo commented 5 months ago

Thanks!

Yes, I have another branch where I'm trying to get this working: https://github.com/SimonKagstrom/kcov/tree/fix-freebsd-python2-tests, which also uses v1 now.

However, for some reason, the bash tests no longer works with this one...

I suspected that you also have patches ready. But why not ubuntu-latest ?

Also, the error from FreeBSD is from "Copy files back from the VM", where there is an error due to a symlink

skipping non-regular file "kcov/kcov/tests/python/link_main"

When "Initialize files in VM" I see

kcov/kcov/tests/python/link_main -> main

but in this case there is error.

perillo commented 5 months ago

However, for some reason, the bash tests no longer works with this one...

I suspect the reason is that the default shell in FreeBSD may be tcsh. So /bin/sh can use tcsh instead of a POSIX shell. But this does not explain why it worked in the past.

SimonKagstrom commented 5 months ago

It turned out to be a problem with file descriptor numbers. I fixed it with e27cb33e5b25b48689eda1178133e7ec90f20c43 in the PR, which basically just disables it for FreeBSD. I don't think it's a very big issue.

Probably broke with the newer FreeBSD I guess.

As for ubuntu-latest, I'm sort of worried that the FreeBSD build will break again when 24.04 is released soonish. :-)

SimonKagstrom commented 5 months ago

Anyway, I'll close this PR since pretty much the same change is also part of #422, but thanks a lot for the discussion and insights!

perillo commented 5 months ago

Thanks to you.