Closed perillo closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 65.68%. Comparing base (
bc0a626
) to head (eef552a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think that's fine, since this is anyway used in a controlled environment.
I personally just use the run-tests
script directly, when running the tests.
I think that's fine, since this is anyway used in a controlled environment.
I personally just use the
run-tests
script directly, when running the tests.
I use a custom script: https://gist.github.com/perillo/cebd9f82094471b241b961a4f869b0ed
The script use python -m libkcov
, the new way to run the tests (the PR will be pushed soon).
By the way: in the cleanup
function I have listed all the generated files; is there a reason why main.log
, thread.log
and .debug
are not written in /tmp
?
In a future PR I plan to move these files to $TMPDIR
and later add cleanup functions to remove them. The purpose it enabling support for looping the tests N time (e.g go test -count N
); I prefer to not have these files around.
Not that I can remember, although it was a long time since I initially set this up, so feel free to relocate them as you wish!
The run function is incorrect, since it does not accept additional arguments.
Don't use
pwd
for sources directory, since all other paths, excluding /tmp, are relative.Update the ci.yml workflow, removing the "amd64" argument to the ci-run-tests.sh script. It was working because the argument was ignored.
@SimonKagstrom, the change from "
pwd
" to"."
may be controversial. Let me know what you think. I use it in mytest.sh
script, when testing locally.