SimonKagstrom / kcov

Code coverage tool for compiled programs, Python and Bash which uses debugging information to collect and report data without special compilation options
http://simonkagstrom.github.io/kcov/
GNU General Public License v2.0
709 stars 109 forks source link

Additional test fixes #435

Closed perillo closed 4 months ago

perillo commented 4 months ago

NOTES

I'm not fully sure about commit "tests: fix test_compiled.address_sanitizer_coverage test".

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.68%. Comparing base (b374103) to head (449fec0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #435 +/- ## ========================================== - Coverage 65.70% 65.68% -0.03% ========================================== Files 58 58 Lines 4514 4514 Branches 4171 4171 ========================================== - Hits 2966 2965 -1 - Misses 1548 1549 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SimonKagstrom commented 4 months ago

Thanks, looks good!

The sanitizer coverage collection is also not completely working, and is probably not very interesting anyway (since it still requires special compile options, which is sort of the point of kcov to start with).

And kudos for the very good PR descriptions by the way!

perillo commented 4 months ago

Thanks, looks good!

The sanitizer coverage collection is also not completely working, and is probably not very interesting anyway (since it still requires special compile options, which is sort of the point of kcov to start with).

Yes, I was aware that the sanitizer is not working correctly. The problem is that the old test used assert False to force the test to fail. Now the code is a bit more easy to understand.

And kudos for the very good PR descriptions by the way!

Thanks! Also, thank you for taking your time to review all the changes that I proposed.