search

SimonKagstrom / kcov

Code coverage tool for compiled programs, Python and Bash which uses debugging information to collect and report data without special compilation options
http://simonkagstrom.github.io/kcov/
GNU General Public License v2.0
709 stars 109 forks source link

Linux correct ptrace calls #443

Closed SimonKagstrom closed 1 month ago

SimonKagstrom commented 1 month ago

@williamdes I sort of stole this, but the cast was really only needed for PowerPC, so it has been removed on all other architectures with this PR.

Unrelated to that, I added DOCKER_USERNAME+DOCKER_PASSWORD to the environment secrets now. Is there anything else to do, or will that work by magic after that?

williamdes commented 1 month ago

Unrelated to that, I added DOCKER_USERNAME+DOCKER_PASSWORD to the environment secrets now. Is there anything else to do, or will that work by magic after that?

Nothing more, you should not see the secrets anymore in the normal secret list now. Did you use a token and not a password ?

I hesitated to use vars.DOCKER_USERNAME but it would have broken the setup. Feel free to move the username to a variable as it is not sensitive and can help with debug sometimes.

SimonKagstrom commented 1 month ago

Didn't move to a token yet, need to readup a bit more first!

williamdes commented 1 month ago

Didn't move to a token yet, need to readup a bit more first!

Sure https://hub.docker.com/settings/security