Feature/golang implementation

SimonRice / bitrise-step-sentry-upload

Sentry Symbol Upload Step for Bitrise

MIT License

3 stars 5 forks source link

Feature/golang implementation #4

Closed jamieastley closed 3 years ago

jamieastley commented 3 years ago

Closes #3

Implement step in Go
Supports either/both Android (Proguard mapping) or iOS dSYM
Add initial unit tests
Github Actions CI tests

SimonRice commented 3 years ago

Just minor tidbits so far, and I've learned quite a bit from Go as it is! Thank you so much for this!

I'm still yet to give it a spin on a sample iOS project I've been using to test this action, but I'll totally do so before merging.

jamieastley commented 3 years ago

no worries! I gave it a spin on our Flutter app CI build yesterday and it worked flawlessly 🚀

jamieastley commented 3 years ago

@SimonRice above PR comments have been addressed.

Slightly off topic to this PR, but since you said you were open to renaming the step to reflect the additional functionality, would you be opposed to making it even more generic so as to add other functionality to the step?

Personally I'd like to add Suspect Commit Tracking to this step as this doesn't currently exist for Bitrise. Thoughts?

SimonRice commented 3 years ago

👍

I'll open up a separate ticket around discussion of renaming this build step, but the important thing is it works now 🎉