search

SimpleMachines / SMF

Simple Machines Forum — SMF in short — is free and open-source community forum software, delivering professional grade features in a package that allows you to set up your own online community within minutes!
https://www.simplemachines.org/
Other
582 stars 251 forks source link

spider log incorrect text #5524

Closed illori closed 4 years ago

illori commented 5 years ago

Description

Note that logging of every spider action only occurs if tracking is set to either "high" or "very high". Detail of every spiders action is only logged if tracking is set to "very high".

high or very high no longer exist

Steps to reproduce

  1. admin -> forum -> search engines -> spider log

Environment (complete as necessary)

Additional information/references

current levels are


Standard - Logs minimal spider activity.
Moderate - Provides more accurate statistics.
Aggressive - Same as "Moderate", but logs data about each page visited.```
live627 commented 5 years ago

More info related to this issue:

grep -nHIirF -- Note that logging of every spider (in directory: D:\repos\SMF2.1\)
./Themes/default/languages/Search.english.php:111:$txt['spider_mode_note'] = 'Note that logging of every spider action only occurs if tracking is set to either "moderate" or "aggressive". Detail of every spider\'s action is only logged if tracking is set to "aggressive".';
./Themes/default/languages/Search.english.php:148:$txt['spider_logs_info'] = 'Note that logging of every spider action only occurs if tracking is set to either "high" or "very high". Detail of every spiders action is only logged if tracking is set to "very high".';
Search completed with 2 matches.

This issue has existed even in 2.0.

illori commented 5 years ago

no this does not exist in 2.0, the text was not updated in 2.1 from the 2.0 text.

sbulen commented 5 years ago

@live627 - were you going to submit that PR?

live627 commented 5 years ago

https://github.com/SimpleMachines/SMF2.1/pull/5554