search

Simsilica / SimArboreal-Editor

Editor using the SimArboreal library to generate exportable tree models.
http://simsilica.github.io/SimArboreal-Editor/
10 stars 6 forks source link

Error loading materials using FixedPipeline LightMode in jme 3.2 #3

Closed Ali-RS closed 7 years ago

Ali-RS commented 7 years ago

Hi FixedPipeline light mode is removed in jme 3.2 so running SimArboreal-Editor with jme 3.2 jars I am getting 

java.lang.UnsupportedOperationException
    at com.jme3.material.plugins.J3MLoader.readTechnique(J3MLoader.java:655)
    at com.jme3.material.plugins.J3MLoader.loadFromRoot(J3MLoader.java:777)
    at com.jme3.material.plugins.J3MLoader.load(J3MLoader.java:798)
    at com.jme3.asset.DesktopAssetManager.loadLocatedAsset(DesktopAssetManager.java:259)
    at com.jme3.asset.DesktopAssetManager.loadAsset(DesktopAssetManager.java:373)
    at com.jme3.material.Material.<init>(Material.java:108)
    at com.simsilica.arboreal.GroundState.initialize(GroundState.java:130)
    at com.simsilica.lemur.event.BaseAppState.initialize(BaseAppState.java:75)
    at com.jme3.app.state.AppStateManager.initializePending(AppStateManager.java:251)
    at com.jme3.app.state.AppStateManager.update(AppStateManager.java:281)
    at com.jme3.app.SimpleApplication.update(SimpleApplication.java:236)
    at com.jme3.system.lwjgl.LwjglAbstractDisplay.runLoop(LwjglAbstractDisplay.java:151)
    at com.jme3.system.lwjgl.LwjglDisplay.runLoop(LwjglDisplay.java:193)
    at com.jme3.system.lwjgl.LwjglAbstractDisplay.run(LwjglAbstractDisplay.java:232)
    at java.lang.Thread.run(Thread.java:745)

should I make a PR and change all 

Technique {
        LightMode FixedPipeline
    }

to SinglePass, in following materials ?

pspeed42 commented 7 years ago

I think those techniques can just be removed, right? There is already a multipass.

I mean, adding single pass techniques might be nice but that's not the same as the FixedPipeline. There is no fixed pipeline anymore so techniques specific to that should just go away I guess.

Ali-RS commented 7 years ago

Hm, yes, I removed them and it works fine now. Should I make a PR ?

pspeed42 commented 7 years ago

That would be great.

Ali-RS commented 7 years ago

Fixed #4