search

SinTh0r4s / ExampleMod1.7.10

An example mod for Minecraft 1.7.10 with Forge focussed on a stable setup.
MIT License
28 stars 103 forks source link

idea complaining about gitVersion and versionDetails #36

Closed bombcar closed 2 years ago

bombcar commented 2 years ago

image

is there perhaps a plugin I'm missing?

I did brew install gitversion and I get reasonable output:

{
  "Major": 9,
  "Minor": 12,
  "Patch": 8,
  "PreReleaseTag": "DrParadox7-master.1",
  "PreReleaseTagWithDash": "-DrParadox7-master.1",
  "PreReleaseLabel": "DrParadox7-master",
  "PreReleaseLabelWithDash": "-DrParadox7-master",
  "PreReleaseNumber": 1,
  "WeightedPreReleaseNumber": 1,
  "BuildMetaData": 6,
  "BuildMetaDataPadded": "0006",
  "FullBuildMetaData": "6.Branch.DrParadox7-master.Sha.e3a78fe1857d3715c2ee3faeec66848e5171dad2",
  "MajorMinorPatch": "9.12.8",
  "SemVer": "9.12.8-DrParadox7-master.1",
  "LegacySemVer": "9.12.8-DrParadox7-master1",
  "LegacySemVerPadded": "9.12.8-DrParadox7-maste0001",
  "AssemblySemVer": "9.12.8.0",
  "AssemblySemFileVer": "9.12.8.0",
  "FullSemVer": "9.12.8-DrParadox7-master.1+6",
  "InformationalVersion": "9.12.8-DrParadox7-master.1+6.Branch.DrParadox7-master.Sha.e3a78fe1857d3715c2ee3faeec66848e5171dad2",
  "BranchName": "DrParadox7_master",
  "EscapedBranchName": "DrParadox7-master",
  "Sha": "e3a78fe1857d3715c2ee3faeec66848e5171dad2",
  "ShortSha": "e3a78fe",
  "NuGetVersionV2": "9.12.8-drparadox7-maste0001",
  "NuGetVersion": "9.12.8-drparadox7-maste0001",
  "NuGetPreReleaseTagV2": "drparadox7-maste0001",
  "NuGetPreReleaseTag": "drparadox7-maste0001",
  "VersionSourceSha": "1e26a2674a2eb0b39e16da4a8acd2013f299d74a",
  "CommitsSinceVersionSource": 6,
  "CommitsSinceVersionSourcePadded": "0006",
  "UncommittedChanges": 0,
  "CommitDate": "2021-11-30"
}

but building Railcraft (for example) produces a Railcraft-1.7.10-latest-2-ge3a78fe.jar which apparently has no version number

bombcar commented 2 years ago

The rail craft thing is caused by

"modVersion": versionDetails().lastTag,

which pulls is getting 'latest' even though:

git describe
9.12.6-11-ge3a78fe1
bombcar commented 2 years ago

ah this is because it does git describe --tags --always --first-parent which is making latest.

https://github.com/palantir/gradle-git-version/issues/55 may be related

removing --tags fixes it but don't know how to make gradle-git do that

bombcar commented 2 years ago

ok I have to tag beyond the current version to get it to work.

we should detect "latest" and error out; it'll never work.

SinTh0r4s commented 2 years ago

latest was removed completely. It caused too many issues.