search

Sinderella / epherousa

1 stars 0 forks source link

Proxy support? #24

Open Sinderella opened 7 years ago

Sinderella commented 7 years ago

As the searchers are all using self.session, it's easy to add proxy support.

ngkogkos commented 7 years ago

Thing is why would someone need to use proxy? If there are use cases, then why not!

danielthatcher commented 7 years ago

We should probably respect the http_proxy environment variable on Unix systems if it's set. I don't know requests already respects this though.

Either way, we should add this as a command line argument anyway.

Sinderella commented 7 years ago

Might need a new object for this as I don't want to do this every request.

req.get(url, proxies=self.proxies)

Do it later then :laughing:

Sinderella commented 7 years ago

Just HTTP proxy or socks as well? socks will require more dependency, see http://docs.python-requests.org/en/master/user/advanced/#socks

It wouldn't be hard though