search

SinusBot / installer-linux

💾 SinusBot Installer for Debian, Ubuntu and CentOS - Installs the SinusBot with a single command.
https://sinusbot.github.io/installer/
Other
35 stars 34 forks source link

Incorrect cron entry for ytdl updates #61

Closed NielsH closed 6 years ago

NielsH commented 6 years ago

Hello,

The SinusBot installer script installs ytdl and adds a cron-entry to automatically update this tool. It does that by creating /etc/cron.d/ytdl which contains:

0 0 * * * sinusbot youtube-dl -U --restrict-filename >/dev/null

However, on Debian 8 at least, this cron fails. This is because youtube-dl is located in /usr/local/bin/youtube-dl and the default PATH in the cron file is /usr/bin:/bin.

I fixed it for now by changing the cron to this:

0 0 * * * sinusbot PATH=$PATH:/usr/local/bin; youtube-dl -U --restrict-filename >/dev/null

However, I am not sure if the cron can be overwritten automatically by an update from SinusBot at some point, which is why I am reporting it here.

DAThosting commented 6 years ago

Fixed with https://github.com/SinusBot/installer-linux/commit/466a94c4bb03a0e10162a33ab67d35fb5621ad47