search

Sinytra / Connector

A compatibility layer that allows running Fabric mods on NeoForge
https://sinytra.org/docs/connector
MIT License
504 stars 20 forks source link

modded ores, whether from fabric mods under sintra or forge mods, dont generate with modern beta world type… #690

Open GameMasterPDX opened 8 months ago

GameMasterPDX commented 8 months ago

Mod Name

Modern Beta

Mod Homepage

https://www.curseforge.com/minecraft/mc-mods/modern-beta

Minecraft version

1.20.1

Describe the bug

modded ores, whether from fabric mods under sintra or forge mods, dont generate with modern beta world type, even though when running completely on fabric custom ores do generate with modern beta world type

Steps to reproduce

  1. Install any mod that has custom ore
  2. Create a Modern Beta world
  3. Explore and see no modded ore generates

Logs

im sorry but im unable to provide the debug.log right now

Additional context

this issue doesnt happen when running on fabric, only with sintra, and i tested this by using tech reborn to test that fabric mods dont generate ores, and create (forge) to test that forge mods dont generate ores, also idk if this is the right issue type its my first time reporting a issue

Cixon commented 5 months ago

oh this has been a issue for quite sometime it appears...just odd that ModernBeta can pull Iron's Spellbooks structures and not some other forge mods...

Cixon commented 5 months ago

I have a theory on this bug

Firstly, some modded content such as biomes and ores appear out the box with modern_beta worldtype. For those pesky mods that DONT, see guide here to adding it yourself. Modern_Beta.

964

@Su5eD regarding modded structures -- I did some bug testing with various structure mods and noticed something. It appears forge mod structures that utilize "type": "minecraft:jigsaw" work mostly out of box once you add modern_beta biome compat via data\structuremod\tags\worldgen\biome\has_structure.

"type": "minecraft:jigsaw"

However, if the structure DOES NOT use this method and something custom, it simply will not generate. You can test this theory by installing 2 mods that use different pool methods.

Jigsaw method: https://legacy.curseforge.com/minecraft/mc-mods/irons-spells-n-spellbooks Custom method: https://legacy.curseforge.com/minecraft/mc-mods/it-takes-a-pillage

Here's a data-pack that allows those structures to spawn in modern_beta biomes: test_modern_beta_compat.zip

I really hope a fix can be applied soon, this is a bit of a alarming issue for some mod-pack creators I'd imagine. Not entirely sure if this applies for other fabric world-type generation mods out there but it occurs for Modern Beta.

Cixon commented 5 months ago

If this theory is true, this might as well be its own bug.