Sinytra / ConnectorExtras

Integrating Connector with third-party APIs
https://modrinth.com/mod/connector-extras
MIT License
19 stars 7 forks source link

Geckolib Fabric/SoulsWeapons/Ars Nouveau crash #11

Closed Zainyest closed 1 year ago

Zainyest commented 1 year ago

Describe the bug

Using Geckolib fabric or forge with Marium Soulslike Weaponry and Ars Nouveau Crashes during initialization.

Steps to reproduce

  1. Compile & install newest branch of ConnectorExtras with the newest releases for connector; install the following mods: image

  2. Launch MC.

  3. Experience crash during initialization.

Logs

https://pastebin.com/nh33zQV4

Additional context

Compiled the dev master branch for ConnectorExtras to get past a pehkui mixin error but got a different geckolib error during startup. Looking at other issues here, it seems other mods that can use geckolib fabric are present like Bosses of Mass Destruction but some cannot.

Zainyest commented 1 year ago

Woah those logs don't look right, lemme try uploading again lol

Zainyest commented 1 year ago

used pastebin and it worked

Zainyest commented 1 year ago

Tested without Ars Nouveau and works fine, probably something to do with Souls wanting a fabric version and ConnectorExtras adding a forge bridge. Without Soulslike Weaponry the fabric version of GeckoLib works fine with Ars Nouveau as well.

ghost commented 1 year ago

The issue is that Marium’s Soulslike uses Fabric Geckolib, and Ars uses Forge Geckolib. You can’t use these mods together because Geckolib is weird. You have to choose one.

Zainyest commented 1 year ago

The issue is that Marium’s Soulslike uses Fabric Geckolib, and Ars uses Forge Geckolib. You can’t use these mods together because Geckolib is weird. You have to choose one.

Yeah, some of the time; but some mods do work with fabric and Ars, like Bosses of Mass Destruction which is why I added this as an issue. (just tested BOMD with the modlist here and it works without soulslike)

coco875 commented 1 year ago

Related to https://github.com/Sinytra/Connector/issues/231

coco875 commented 1 year ago

The issue is that Marium’s Soulslike uses Fabric Geckolib, and Ars uses Forge Geckolib. You can’t use these mods together because Geckolib is weird. You have to choose one.

It's more complicated it's because ars nouveau have geckolib in the mod and so like forge mod are load before fabric he use this version of geckolib instead of the fabric version

Su5eD commented 1 year ago

The error happens because Geckolib for Fabric and Forge have different code - they're not using a multiloader layout like other libraries.

I'll close this in favor of Sinytra/Connector#231 where geckolib compat is being tracked.