search

Sinytra / ConnectorExtras

Integrating Connector with third-party APIs
https://modrinth.com/mod/connector-extras
MIT License
19 stars 7 forks source link

Add JEI bridge #22

Closed Abbie5 closed 11 months ago

Abbie5 commented 11 months ago

Marking as draft as it currently doesn't seem to relocate/inject API classes properly, help would be appreciated :)

Su5eD commented 11 months ago

Sure, I can have a look at that part. Is there anything else required to bridge the APIs?

Abbie5 commented 11 months ago

No I checked those are the only classes exclusive to the JEI Fabric API (https://github.com/mezz/JustEnoughItems/tree/1.20/FabricApi/src/main/java/mezz/jei/api/fabric)

Abbie5 commented 11 months ago

Ah I may have misunderstood, I tested this and the plugin loading worked fine, the only issue was the JEI Fabric API classes not being loaded with log messages such as java.lang.ClassNotFoundException: mezz.jei.api.fabric.constants.FabricTypes

Su5eD commented 11 months ago

The relocation code can be safely removed. JEI puts its fabric-specific classes in a unique mezz.jei.api.fabric package, which doesn't exist on the forge version, and therefore it won't cause issues unlike the emi bridge.

Abbie5 commented 11 months ago

Ah that's a relief