SirJohnK / LocalizationResourceManager.Maui

Enhanced .NET MAUI version of the XCT LocalizationResourceManager.
MIT License
140 stars 9 forks source link

Suggestion: reuse `ObservableObject` from MVVM Community Toolkit #29

Open hansmbakker opened 2 weeks ago

hansmbakker commented 2 weeks ago

I see you added ObservableObject which is also available from the MVVM Community Toolkit.

Reusing the class from that library would allow to maintain less code yourself.

SirJohnK commented 1 week ago

2 reasons for this:

I am a big fan of the MVVM Community Toolkit and use it in all my applications, but in this specific case I think I have a good reason to not use it. 😄

I really appreciate the input and that you take the time to make this a better library! 👍

hansmbakker commented 1 week ago

Aah, I never used WeakEventManager and was not aware of the memory leaks - I'm using WeakReferenceMessenger (without a dependency on maui) but I guess WeakEventManager has a different purpose for you?