search

SitePen / dgrid

A lightweight, mobile-ready, data-driven, modular grid widget designed for use with dstore
http://dgrid.io/
Other
628 stars 295 forks source link

Propagate resolved value of 'renderQuery' promise through 'refresh' #1315

Closed msssk closed 4 years ago

msssk commented 8 years ago

The renderQuery method returns a promise that resolves to an array of the rendered row elements. It appears to be an oversight that this value is discarded by the refresh method.

kfranqueiro commented 8 years ago

IIUC, Pagination#refresh currently returns results, not rows, so this would be somewhat inconsistent. I think it should be possible to return results rather than rows here too though, so would that be a better idea?