Sivapsg / google-refine

Automatically exported from code.google.com/p/google-refine
0 stars 0 forks source link

Maximum number of facet values should be configurable. #31

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. For any column that contains more than 2000 unique values select Facet
-> Text Facet from the header.

What is the expected output? What do you see instead?

The facet sidebar displays "Too many choices" rather than all discrete values.

What version of the product are you using? On what operating system?

SVN HEAD on OSX.

Please provide any additional information below.

This value should be configurable either in flat-text or in the UI. 
Although there is a definite performance boundary, I found with my very
first dataset that I needed to support upwards of 3000 unique values in a
facet, but could not do so without modifying the source.

Original issue reported on code.google.com by staringmonkey on 14 May 2010 at 1:40

GoogleCodeExporter commented 9 years ago
David, Stefano - Is the limit in compiled code?  Values like these should be in 
a 
separate configuration text file at least.

Original comment by iainsproat on 14 May 2010 at 3:21

GoogleCodeExporter commented 9 years ago
It is in src/main/java/com/metaweb/gridworks/browsing/facets/ListFacet.java, on 
line
68.  Easy to change, but still annoying. :-)

Original comment by staringmonkey on 14 May 2010 at 3:26

GoogleCodeExporter commented 9 years ago
Yeah, agreed, it should be easier to configure. I'll make it configurable.

Original comment by stefano.mazzocchi@gmail.com on 14 May 2010 at 4:15

GoogleCodeExporter commented 9 years ago
I think as the first cut, we can have a .properties file storing all these 
settings. We 
don't have to have UI yet.

Original comment by dfhu...@gmail.com on 14 May 2010 at 4:26

GoogleCodeExporter commented 9 years ago
I also just stumbled on this annoyance. 

1) I would like a message on what number of items that was found, or at least 
what
the limit was.
2) I would like some suggestion on what to do to get the values. ie. 
"Complement this
with a search to see your values" or "Click here to change the maximum value".

Original comment by EmilStenstrom on 20 May 2010 at 9:15

GoogleCodeExporter commented 9 years ago
In trunk, you can go to http://127.0.0.1:3333/preferences and set the facet 
limit using the preference key "ui.browsing.listFacet.limit". I'm not sure how 
to expose this through a more user-friendly UI just yet.

Original comment by dfhu...@google.com on 6 Aug 2010 at 6:17

GoogleCodeExporter commented 9 years ago

Original comment by iainsproat on 14 Oct 2010 at 9:25

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2201.

Original comment by dfhu...@google.com on 14 Aug 2011 at 1:05

GoogleCodeExporter commented 9 years ago
Fixed by r2201.

Original comment by dfhu...@gmail.com on 14 Aug 2011 at 1:06

GoogleCodeExporter commented 9 years ago

Original comment by dfhu...@google.com on 9 Oct 2011 at 5:09

GoogleCodeExporter commented 9 years ago
Preferences was a great fix for this.  Thank you! :)

Original comment by kiminoa on 24 Apr 2012 at 4:07